Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DO NOT MERGE: For internal review of conda build only #2

Closed
wants to merge 54 commits into from

Conversation

christinaholtNOAA
Copy link
Owner

--- Delete this line and those above before hitting "Create pull request" ---

DESCRIPTION OF CHANGES:

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

TESTS CONDUCTED:

  • hera.intel
  • orion.intel
  • cheyenne.intel
  • cheyenne.gnu
  • gaea.intel
  • jet.intel
  • wcoss2.intel
  • NOAA Cloud (indicate which platform)
  • Jenkins
  • fundamental test suite
  • comprehensive tests (specify which if a subset was used)

DEPENDENCIES:

DOCUMENTATION:

ISSUE:

CHECKLIST

  • My code follows the style guidelines in the Contributor's Guide
  • I have performed a self-review of my own code using the Code Reviewer's Guide
  • I have commented my code, particularly in hard-to-understand areas
  • My changes need updates to the documentation. I have made corresponding changes to the documentation
  • My changes do not require updates to the documentation (explain).
  • My changes generate no new warnings
  • New and existing tests pass with my changes
  • Any dependent changes have been merged and published

LABELS (optional):

A Code Manager needs to add the following labels to this PR:

  • Work In Progress
  • bug
  • enhancement
  • documentation
  • release
  • high priority
  • run_ci
  • run_we2e_fundamental_tests
  • run_we2e_comprehensive_tests
  • Needs Cheyenne test
  • Needs Jet test
  • Needs Hera test
  • Needs Orion test
  • help wanted

CONTRIBUTORS (optional):

christinaholtNOAA and others added 30 commits October 6, 2023 22:02
…eously on Orion/Hercules and Gaea/Gaea C5 (ufs-community#921)

With the addition of Gaea C5 and Hercules to the Jenkinsfile, file contention between Gaea and Gaea C5, as well as Orion and Hercules, caused testing to fail for one of these two pairs of machines. While requeuing the failed machine would allow it to work, the automated tests should run automatically on all machines, simultaneously. The Platform team recommended adding the dir command to the stages' step sections in the Jenkinsfile. This has been completed and the Jenkins tests are now running on all machines simultaneously.
…e for new platforms (ufs-community#934)

The option to create an experiment with the option USE_CRON_TO_RELAUNCH=True is currently broken on Cheyenne and Derecho due to some bad python logic. This fixes that issue.

Also took the opportunity to update the PR template to include the new supported platforms (Derecho, Hercules, and Gaea C5)
The note block must be indented to render properly.
Remove reference to the MacMorePackages section. That section was deleted in favor of the conda env installation approach.
…s-community#935)

Added the Sonarqube stage to the Jenkinsfile in the SRW App's GitHub repository.

Additionally, a fix has been made to allow the Functional Workflow Task Tests stage to successfully run on Hera GNU (30 minute wall time isn't enough for the the community test to finish using GNU compiled executables).
Co-authored-by: Gillian Petro <96886803+gspetro-NOAA@users.noreply.github.com>
christinaholtNOAA and others added 24 commits October 18, 2023 19:45
Co-authored-by: Michael Lueken <63728921+MichaelLueken@users.noreply.github.com>
Co-authored-by: Michael Kavulich <kavulich@ucar.edu>
* Add a new comprehensive test suite, comprehensive.gaea-c5, which is a symlink to comprehensive.orion.
* The parm/wflow/verify_pre.yaml file has been updated to give more walltime to APCP.
* A comprehensive test suite has been added for the NOAA cloud platforms (comprehensive.noaacloud).
* load("wget") was added to the build_orion_intel.lua modulefile to allow the get_from_NOMADS_ics_FV3GFS_lbcs_FV3GFS to successfully retrieve data from NOMADS.
* valid_param_vals.yaml has been updated to include the "reuse" option in valid_vals_PREEXISTING_DIR_METHOD.
Co-authored-by: Michael Lueken <63728921+MichaelLueken@users.noreply.github.com>
Co-authored-by: Michael Lueken <63728921+MichaelLueken@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants