Fixed Edgecase Exclusion List Caveat #19
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Not the most elegant solution, but it works
|
Hey @OneTrueC - thanks for putting this up. I'd like to understand the intention of the changes better before merging in. It looks like there are two different cases you're handling, one for preserving UPPERCASE and the other for only matching the whole word for exclusion words. Is that right? If so, I'm wondering if you can share some specific cases for these? |
|
The caveat in the readme states that the exclusion list shouldn't be ignored and uses all caps for examples, so I made my changes under the assumption that the intended behavior was to check both for the beginning and end. As for examples:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not the most elegant solution, but it works.