fix: better support for *

christophehurpeau · Jul 5, 2023 · 1ac69e6 · 1ac69e6
1 parent 437c4e4
commit 1ac69e6
Show file tree

Hide file tree

Showing 7 changed files with 20 additions and 3 deletions.
diff --git a/dist/definitions/checks/checkMinRangeSatisfies.d.ts.map b/dist/definitions/checks/checkMinRangeSatisfies.d.ts.map
diff --git a/dist/definitions/checks/checkPeerDependencies.d.ts.map b/dist/definitions/checks/checkPeerDependencies.d.ts.map
diff --git a/dist/index-node16.mjs b/dist/index-node16.mjs
@@ -155,6 +155,9 @@ function checkPeerDependencies(pkg, reportError, type, allowedPeerIn, providedDe
         if (version.startsWith('npm:')) {
           return;
         }
+        if (version === '*') {
+          return;
+        }
         const minVersionOfVersion = semver.minVersion(version);
         if (!minVersionOfVersion || !semver.satisfies(minVersionOfVersion, range, {
           includePrerelease: true
@@ -328,6 +331,7 @@ function checkMinRangeSatisfies(pkgPathName, pkg, type1 = 'dependencies', type2
   }
   const reportError = customCreateReportError(`"${type1}" minimum range satisfies "${type2}"`, pkgPathName);
   for (const [depName, depRange1] of getEntries(dependencies1)) {
+    if (depRange1 === '*') continue;
     const depRange2 = dependencies2[depName];
     if (!depRange2 || !depRange1) continue;
     const minDepRange1 = semver.minVersion(depRange1)?.version || depRange1;

diff --git a/dist/index-node16.mjs.map b/dist/index-node16.mjs.map
diff --git a/src/checks/checkMinRangeSatisfies.test.ts b/src/checks/checkMinRangeSatisfies.test.ts
@@ -52,6 +52,13 @@ describe(checkMinRangeSatisfies.name, () => {
           devDependencies: { test1: '^1.1.0' },
         },
       ],
+      [
+        '* dependency',
+        {
+          dependencies: { test1: '*' },
+          devDependencies: { test1: '^1.1.0' },
+        },
+      ],
     ])('should have no error when %s', (_, pkgContent) => {
       checkMinRangeSatisfies(
         'path',

diff --git a/src/checks/checkMinRangeSatisfies.ts b/src/checks/checkMinRangeSatisfies.ts
@@ -33,6 +33,8 @@ export function checkMinRangeSatisfies(
   );
 
   for (const [depName, depRange1] of getEntries(dependencies1)) {
+    if (depRange1 === '*') continue;
+
     const depRange2 = dependencies2[depName];
     if (!depRange2 || !depRange1) continue;
 

diff --git a/src/checks/checkPeerDependencies.ts b/src/checks/checkPeerDependencies.ts
@@ -66,6 +66,10 @@ export function checkPeerDependencies(
           return;
         }
 
+        if (version === '*') {
+          return;
+        }
+
         const minVersionOfVersion = semver.minVersion(version);
         if (
           !minVersionOfVersion ||