add print orientation in print options #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -55,6 +55,7 @@ public void print(final ReadableMap options, final Promise promise) { | |||
|
|
|||
| final String html = options.hasKey("html") ? options.getString("html") : null; | |||
| final String filePath = options.hasKey("filePath") ? options.getString("filePath") : null; | |||
| final boolean isLandscape = options.hasKey("isLandscape")?options.getBoolean("isLandscape"):false; | |||
There was a problem hiding this comment.
nit: space between operators.
| @@ -165,6 +165,7 @@ const styles = StyleSheet.create({ | |||
| | `html` | `string` | HTML string to print | |||
| | `fileName` | `string` | Custom Filename excluding .pdf extension or remote file url NOTE: iOS only supports https protocols | |||
| | `printerURL` | `string` | **iOS Only:** URL returned from `selectPrinterMethod()` | |||
| | `isLandscape` | `bool` | Landscape print; defalut value is false | |||
christopherdro
pushed a commit
that referenced
this pull request
Mar 24, 2018
* ios options add isLandscape * 默认打印方向 * update README: add isLandscape in print options
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.