Support arrays of per file ignore options #165
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! Do you mind to make the lint pass? I made the tests run. |
|
I think it wants you to run black as well. |
|
You're welcome. I don't mind at all - given the nature of this project, running a linter should've occured to me sooner. |
for more information, see https://pre-commit.ci
|
Hi Christopher. These latest failures are from lots of different lines being too long, perhaps due to the Black line length setting whose name I changed re-enabled. I've added the same setting to Ruff, and linting seems to pass now on my fork: https://github.com/JamesParrott/pylint-per-file-ignores/actions/runs/12027829692 |
christopherpickering
merged commit 2d589ee
into
christopherpickering:master
3 checks passed
|
Thanks! sorry for the delay here. |
|
No problem. Thanks Christopher :). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm not sure how to test this, and hence am not sure if this works, but perhaps this fixes #160?