fix(core): Show all app selections when creating a pipeline from mptv2 (

spinnaker#6891)
christopherthielen · Apr 24, 2019 · 7fde1fa · 7fde1fa
1 parent cd8780c
commit 7fde1fa
Show file tree

Hide file tree

Showing 4 changed files with 11 additions and 5 deletions.
diff --git a/app/scripts/modules/core/src/pipeline/config/templates/v2/PipelineTemplatesV2.tsx b/app/scripts/modules/core/src/pipeline/config/templates/v2/PipelineTemplatesV2.tsx
@@ -6,7 +6,7 @@ import { Subscription } from 'rxjs';
 import { UISref } from '@uirouter/react';
 
 import { PipelineTemplateV2Service } from './pipelineTemplateV2.service';
-import CreatePipelineFromTemplate from './CreatePipelineFromTemplate';
+import { CreatePipelineFromTemplate } from './createPipelineFromTemplate';
 import { IPipelineTemplateV2 } from 'core/domain/IPipelineTemplateV2';
 import { ShowPipelineTemplateJsonModal } from 'core/pipeline/config/actions/templateJson/ShowPipelineTemplateJsonModal';
 import { ReactInjector, IStateChange } from 'core/reactShims';

diff --git a/...mplates/v2/CreatePipelineFromTemplate.tsx → ...omTemplate/CreatePipelineFromTemplate.tsx b/...mplates/v2/CreatePipelineFromTemplate.tsx → ...omTemplate/CreatePipelineFromTemplate.tsx
@@ -4,14 +4,16 @@ import { Option } from 'react-select';
 import { Observable, Subject } from 'rxjs';
 
 import { Application, ApplicationReader, IApplicationSummary } from 'core/application';
-import ApplicationSelector from './ApplicationSelector';
+import ApplicationSelector from '../ApplicationSelector';
 import { CreatePipelineModal } from 'core/pipeline';
 import { IPipelineTemplateV2 } from 'core/domain/IPipelineTemplateV2';
 import { ReactInjector } from 'core/reactShims';
 import { Spinner } from 'core/widgets/spinners/Spinner';
 import { SubmitButton } from 'core/modal/buttons/SubmitButton';
 
-export interface ICreatePipelineFromTemplateProps {
+import './createPipelineFromTemplate.less';
+
+interface ICreatePipelineFromTemplateProps {
   closeModalCallback: () => void;
   template: IPipelineTemplateV2;
 }
@@ -26,7 +28,7 @@ interface ICreatePipelineFromTemplateState {
   submitting: boolean;
 }
 
-export default class CreatePipelineFromTemplate extends React.Component<
+export class CreatePipelineFromTemplate extends React.Component<
   ICreatePipelineFromTemplateProps,
   ICreatePipelineFromTemplateState
 > {
@@ -128,7 +130,7 @@ export default class CreatePipelineFromTemplate extends React.Component<
     }
 
     return (
-      <Modal show={true} onHide={closeModalCallback}>
+      <Modal show={true} onHide={closeModalCallback} className="create-pipeline-from-template-modal">
         <Modal.Header closeButton={true}>
           <Modal.Title>Select An Application</Modal.Title>
         </Modal.Header>

diff --git a/...c/pipeline/config/templates/v2/createPipelineFromTemplate/createPipelineFromTemplate.less b/...c/pipeline/config/templates/v2/createPipelineFromTemplate/createPipelineFromTemplate.less
@@ -0,0 +1,3 @@
+.create-pipeline-from-template-modal .modal-content {
+  overflow: visible;
+}
diff --git a/...scripts/modules/core/src/pipeline/config/templates/v2/createPipelineFromTemplate/index.ts b/...scripts/modules/core/src/pipeline/config/templates/v2/createPipelineFromTemplate/index.ts
@@ -0,0 +1 @@
+export * from './CreatePipelineFromTemplate';