-
Notifications
You must be signed in to change notification settings - Fork 204
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Webpack bundle #56
base: master
Are you sure you want to change the base?
Webpack bundle #56
Conversation
Any chance of resolving the conflicts? |
Apologies for not responding earlier. If you have to cater for older browsers, perhaps you could use v1.1.3, which is ES5. I have no experience with bundlers myself, and don't really want to get pulled into catering for not just webpack, but potentially rollup, parcel, and maybe others... |
@chrisveness Just wondering if you would reconsider, or accept a clean PR for webpack, it would also make it easier to use with the other bundlers. Related to #90 |
I've not used webpack, but looking at webpack.js.org/guides/ecma-script-modules, it seems that webpack can now handle ES Modules natively? – "by default webpack will automatically detect whether a file is an ESM or a different module system". Otherwise, not being a webpack user, I don't know how it would handle the Mostly, though, it's not just webpack – I'm no more familiar with alternatives such as browserify, rollup, parcel, etc, which would probably have equal claim to configuration being included. |
I have a fork of this PR and it's pretty out of date and still needs work, so we should probably close this PR. It's probably better to tackle it from the angle Zack was proposing in #90 and if/when he is available again I can ask him, or figure it out. |
Hi @chrisveness,
I did a simple webpack bundle configuration for my clients' needs with older browsers. So I needed the ES5 support in my application.
What I did is creating a configuration file
webpack.config.js
andbundle.js
to customize the naming under the global variable geodesy in the browser. moreover, added the following development dependenciesbabel-core babel-loader@7 webpack webpack-cli
The future is not ES5 or older so the I did not make any changes to the library. I just added my work independently. I hope this helps and I am thankful for your work.