Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Webpack bundle #56

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

mohmmad1024
Copy link

@mohmmad1024 mohmmad1024 commented Apr 28, 2019

Hi @chrisveness,

I did a simple webpack bundle configuration for my clients' needs with older browsers. So I needed the ES5 support in my application.

What I did is creating a configuration file webpack.config.js and bundle.js to customize the naming under the global variable geodesy in the browser. moreover, added the following development dependencies babel-core babel-loader@7 webpack webpack-cli

The future is not ES5 or older so the I did not make any changes to the library. I just added my work independently. I hope this helps and I am thankful for your work.

@mohmmad1024 mohmmad1024 marked this pull request as ready for review April 28, 2019 20:26
@arthur-clifford
Copy link

Any chance of resolving the conflicts?
Having an ie compatible version would help with a project of mine where ie is a desired legacy browser to support.

@chrisveness
Copy link
Owner

Apologies for not responding earlier.

If you have to cater for older browsers, perhaps you could use v1.1.3, which is ES5.

I have no experience with bundlers myself, and don't really want to get pulled into catering for not just webpack, but potentially rollup, parcel, and maybe others...

@ivanoats
Copy link

ivanoats commented Dec 1, 2020

@chrisveness Just wondering if you would reconsider, or accept a clean PR for webpack, it would also make it easier to use with the other bundlers. Related to #90

@chrisveness
Copy link
Owner

I've not used webpack, but looking at webpack.js.org/guides/ecma-script-modules, it seems that webpack can now handle ES Modules natively? – "by default webpack will automatically detect whether a file is an ESM or a different module system".

Otherwise, not being a webpack user, I don't know how it would handle the main/multiple entry points issue highlighted in #90. The ESM loader handles all the inter-dependencies illustrated in www.movable-type.co.uk/scripts/geodesy-library.html#class-dependencies.

Mostly, though, it's not just webpack – I'm no more familiar with alternatives such as browserify, rollup, parcel, etc, which would probably have equal claim to configuration being included.

@ivanoats
Copy link

ivanoats commented Dec 1, 2020

I have a fork of this PR and it's pretty out of date and still needs work, so we should probably close this PR. It's probably better to tackle it from the angle Zack was proposing in #90 and if/when he is available again I can ask him, or figure it out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants