Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENH]: Resiliency for local observability #1931

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

tazarov
Copy link
Contributor

@tazarov tazarov commented Mar 26, 2024

Description of changes

Summarize the changes made by this PR.

  • Improvements & Bug fixes
    • Added rate-limiter, batching and Zipkin Storage (MariaDB/MySQL) to make the local observability stack more resilient to failures

Test plan

How are these changes tested?

Manual test

Documentation Changes

N/A

Copy link
Contributor Author

tazarov commented Mar 26, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @tazarov and the rest of your teammates on Graphite Graphite

Copy link

Reviewer Checklist

Please leverage this checklist to ensure your code review is thorough before approving

Testing, Bugs, Errors, Logs, Documentation

  • Can you think of any use case in which the code does not behave as intended? Have they been tested?
  • Can you think of any inputs or external events that could break the code? Is user input validated and safe? Have they been tested?
  • If appropriate, are there adequate property based tests?
  • If appropriate, are there adequate unit tests?
  • Should any logging, debugging, tracing information be added or removed?
  • Are error messages user-friendly?
  • Have all documentation changes needed been made?
  • Have all non-obvious changes been commented?

System Compatibility

  • Are there any potential impacts on other parts of the system or backward compatibility?
  • Does this change intersect with any items on our roadmap, and if so, is there a plan for fitting them together?

Quality

  • Is this code of a unexpectedly high quality (Readability, Modularity, Intuitiveness)

@tazarov tazarov marked this pull request as ready for review March 27, 2024 19:28
Copy link
Contributor

@beggers beggers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need this? have users asked for it?

@tazarov
Copy link
Contributor Author

tazarov commented Mar 28, 2024

@beggers, I was supporting a user where we had to do some tracing but for Zipkin kept crashing so we had to do this change. So decided to contribute it back to our local observatory.

It is not strictly needed, but for tracing non-trivial use cases it is really helpful.

Copy link
Contributor

@beggers beggers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems quite reasonable. Just a small request for documentation :^)

@tazarov tazarov force-pushed the trayan-03-26-feat_resiliency_for_local_observability branch from 88afaf5 to 2333793 Compare April 17, 2024 12:03
@tazarov tazarov force-pushed the trayan-03-26-feat_resiliency_for_local_observability branch from 2333793 to 61e9f59 Compare September 17, 2024 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants