[ENH] add included to .get() & .query() response
#2044
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Clarifies behavior when fields like `embeddings` are returned as `None`.
Reviewer ChecklistPlease leverage this checklist to ensure your code review is thorough before approving Testing, Bugs, Errors, Logs, Documentation
System Compatibility
Quality
|
codetheweb
force-pushed
the
feat-get-query-returns-included
branch
3 times, most recently
from
6ea9699
to
d8e0bf0
Compare
1 task
codetheweb
force-pushed
the
feat-get-query-returns-included
branch
from
d8e0bf0
to
5e59276
Compare
HammadB
reviewed
Apr 30, 2024
| @@ -1290,6 +1319,8 @@ def test_get_nearest_neighbors_where_n_results_more_than_element(api): | |||
| for key in results.keys(): | |||
| if key in includes or key == "ids": | |||
| assert len(results[key][0]) == 2 | |||
| elif key == "included": | |||
There was a problem hiding this comment.
oh for future reference, this is really a grab bag of tests, we try to pull tests out on-demand, we can leave for now
HammadB
approved these changes
Apr 30, 2024
|
👏 |
1 task
HammadB
added a commit
that referenced
this pull request
Apr 30, 2024
## Description of changes *Summarize the changes made by this PR.* - Improvements & Bug fixes - Ran prettier to fix breakage lint rule breakge in #2044 - New functionality - ... ## Test plan *How are these changes tested?* Lint CI failed, this is a fix - [x] Tests pass locally with `pytest` for python, `yarn test` for js, `cargo test` for rust ## Documentation Changes *Are all docstrings for user-facing APIs updated if required? Do we need to make documentation changes in the [docs repository](https://github.com/chroma-core/docs)?*
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Helps clarify behavior when fields like
embeddingsare returned asNone. Not a breaking change.Test plan
How are these changes tested?
pytestfor python,yarn testfor js,cargo testfor rustDocumentation Changes
I didn't see any relevant documentation that needs to be updated.