Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENH] [MEGAPR] Blockfile refactor, compactor job, record segment #2052

Merged
merged 31 commits into from
May 1, 2024

Conversation

HammadB
Copy link
Collaborator

@HammadB HammadB commented Apr 24, 2024

Description of changes

Summarize the changes made by this PR.

  • Improvements & Bug fixes
    • /
  • New functionality
    • This PR contains a very large refactor the blockfile code to make it strongly typed and zero-copy. It is a lot of prototype-quality code. I am getting it merged to test on staging but subsequently will clean this all up. We should not normalize this and its an extreme deviance from the norm.

Test plan

How are these changes tested?

  • Tests pass locally with pytest for python, yarn test for js, cargo test for rust

Documentation Changes

None

Copy link

Reviewer Checklist

Please leverage this checklist to ensure your code review is thorough before approving

Testing, Bugs, Errors, Logs, Documentation

  • Can you think of any use case in which the code does not behave as intended? Have they been tested?
  • Can you think of any inputs or external events that could break the code? Is user input validated and safe? Have they been tested?
  • If appropriate, are there adequate property based tests?
  • If appropriate, are there adequate unit tests?
  • Should any logging, debugging, tracing information be added or removed?
  • Are error messages user-friendly?
  • Have all documentation changes needed been made?
  • Have all non-obvious changes been commented?

System Compatibility

  • Are there any potential impacts on other parts of the system or backward compatibility?
  • Does this change intersect with any items on our roadmap, and if so, is there a plan for fitting them together?

Quality

  • Is this code of a unexpectedly high quality (Readability, Modularity, Intuitiveness)

@HammadB HammadB changed the title [ENH] [MEGAPR] Blockfile refactor, compator job, record segment [ENH] [MEGAPR] Blockfile refactor, compactor job, record segment Apr 24, 2024
@HammadB HammadB force-pushed the hammad/materialized_record_type branch from df7cbcf to dccdb03 Compare April 26, 2024 15:43
@HammadB HammadB force-pushed the hammad/data_record_support_in_blockfile branch from 66ef785 to 1295539 Compare April 26, 2024 15:43
@HammadB HammadB mentioned this pull request Apr 26, 2024
1 task
@HammadB HammadB force-pushed the hammad/materialized_record_type branch from dccdb03 to 768bf5f Compare April 26, 2024 16:22
@HammadB HammadB force-pushed the hammad/data_record_support_in_blockfile branch 2 times, most recently from adce836 to 716fc6f Compare April 26, 2024 16:31
@HammadB HammadB changed the base branch from hammad/materialized_record_type to main April 26, 2024 16:31
@HammadB HammadB force-pushed the hammad/data_record_support_in_blockfile branch from df37229 to 233a63d Compare April 26, 2024 23:41
@HammadB HammadB mentioned this pull request Apr 27, 2024
4 tasks
@HammadB HammadB enabled auto-merge (squash) May 1, 2024 00:45
@HammadB HammadB merged commit eb18e5c into main May 1, 2024
125 checks passed
@HammadB HammadB mentioned this pull request May 17, 2024
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant