Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TST] Enable tests for $ne, $nin, and $not_contains for hosted Chroma #2909

Merged
merged 1 commit into from
Oct 8, 2024
Merged

[TST] Enable tests for $ne, $nin, and $not_contains for hosted Chroma #2909

merged 1 commit into from
Oct 8, 2024

Conversation

Sicheng-Pan
Copy link
Contributor

@Sicheng-Pan Sicheng-Pan commented Oct 7, 2024 •
edited
Loading

Description of changes

Summarize the changes made by this PR.

  • Improvements & Bug fixes
    • Enable the tests for $ne, $nin, and $not_contains on distributed chroma.
  • New functionality
    • N/A

Test plan

How are these changes tested?

  • Tests pass locally with pytest for python, yarn test for js, cargo test for rust

Documentation Changes

Are all docstrings for user-facing APIs updated if required? Do we need to make documentation changes in the docs repository?

@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 7, 2024

Reviewer Checklist

Please leverage this checklist to ensure your code review is thorough before approving

Testing, Bugs, Errors, Logs, Documentation

  • Can you think of any use case in which the code does not behave as intended? Have they been tested?
  • Can you think of any inputs or external events that could break the code? Is user input validated and safe? Have they been tested?
  • If appropriate, are there adequate property based tests?
  • If appropriate, are there adequate unit tests?
  • Should any logging, debugging, tracing information be added or removed?
  • Are error messages user-friendly?
  • Have all documentation changes needed been made?
  • Have all non-obvious changes been commented?

System Compatibility

  • Are there any potential impacts on other parts of the system or backward compatibility?
  • Does this change intersect with any items on our roadmap, and if so, is there a plan for fitting them together?

Quality

  • Is this code of a unexpectedly high quality (Readability, Modularity, Intuitiveness)

@Sicheng-Pan Graphite App
Copy link
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @Sicheng-Pan and the rest of your teammates on Graphite Graphite

@Sicheng-Pan Sicheng-Pan marked this pull request as ready for review October 7, 2024 23:06
@Sicheng-Pan Graphite App
Copy link
Contributor Author

Sicheng-Pan commented Oct 8, 2024 •
edited
Loading

Merge activity

@Sicheng-Pan Sicheng-Pan merged commit 6d878f1 into main Oct 8, 2024
72 checks passed
itaismith pushed a commit that referenced this pull request Oct 10, 2024
@Sicheng-Pan @itaismith
[TST] Enable tests for $ne, $nin, and $not_contains for hosted Chroma (…
cb46fe3 
…#2909)

## Description of changes

*Summarize the changes made by this PR.*
 - Improvements & Bug fixes
	 - Enable the tests for `$ne`, `$nin`, and `$not_contains` on distributed chroma.
 - New functionality
	 - N/A

## Test plan
*How are these changes tested?*

- [x] Tests pass locally with `pytest` for python, `yarn test` for js, `cargo test` for rust

## Documentation Changes
*Are all docstrings for user-facing APIs updated if required? Do we need to make documentation changes in the [docs repository](https://github.com/chroma-core/docs)?*
@Sicheng-Pan Sicheng-Pan deleted the 10-07-_tst_enable_tests_for_ne_nin_and_not_contains_for_hosted_chroma branch November 20, 2024 21:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Sicheng-Pan