Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(axios): Remove max content size limit #367

Closed
wants to merge 1 commit into from

Conversation

jonluca
Copy link

@jonluca jonluca commented Apr 17, 2023

Description of changes

Summarize the changes made by this PR.

  • Improvements & Bug fixes
    • Remove max axios content size/length limit

Test plan

How are these changes tested?
Locally

Documentation Changes

Are all docstrings for user-facing APIs updated if required? Do we need to make documentation changes in the docs repository?

No

@jonluca
Copy link
Author

jonluca commented Apr 17, 2023

Fixes #366

@jonluca
Copy link
Author

jonluca commented Apr 17, 2023

A temporary workaround for anyone experiencing this is to just override the defaults

    // @ts-ignore
    this.collection.api.axios.defaults.maxContentLength = Infinity;
    // @ts-ignore
    this.collection.api.axios.defaults.maxBodyLength = Infinity;

@jeffchuber
Copy link
Contributor

@jonluca thank you for this! there is another PR out to swap axois for fetch for greater support.

#348

I'd like to make that change, but also want to persist this. Do you know if we need something similar for fetch?

@jonluca
Copy link
Author

jonluca commented Apr 17, 2023

Nope you shouldn't need anything like this for fetch - this is an internal axios config. Awesome, looking forward to that PR!

@jeffchuber
Copy link
Contributor

ok great! In that case I am going to close this. thanks @jonluca for doing this however!

my goal is to land the JS stuff tonight

@jeffchuber jeffchuber closed this Apr 17, 2023
@jeffchuber jeffchuber mentioned this pull request Apr 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants