swap axios for fetch in the JS client #409
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jeffchuber for me this does not matter. Feel free to merge this and close my PR :) |
|
@gustawdaniel roger that. all the credit to you - thanks for figuring out the hard edges here! |
HammadB
reviewed
Apr 26, 2023
| // we need to override constructors to make it work with jest | ||
| // https://stackoverflow.com/questions/76007003/jest-tobeinstanceof-expected-constructor-array-received-constructor-array | ||
| function repack(value: unknown): any { | ||
| if (Boolean(value) && typeof value === "object") { |
There was a problem hiding this comment.
does if value give the same semantics here?
HammadB
reviewed
Apr 26, 2023
| function repack(value: unknown): any { | ||
| if (Boolean(value) && typeof value === "object") { | ||
| if (Array.isArray(value)) { | ||
| return new Array(...value); |
There was a problem hiding this comment.
Do we need to handle nested values?
HammadB
reviewed
Apr 26, 2023
clients/js/src/types.ts
Outdated
| Documents = 'documents', | ||
| Embeddings = 'embeddings', | ||
| Metadatas = 'metadatas', | ||
| Distances = 'distances' |
HammadB
approved these changes
Apr 26, 2023
|
Approved pending comments! |
|
Can you merge this one? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All the good stuff here is credit of @gustawdaniel . This separate PR is mainly handling merge conflicts from
mainmoving on with additional functionality.#348
This PR
axiosforfetchper JS/TS + Misc Feedback #254prettier@gustawdaniel feel free to push up this PR separately and I'll merge yours instead
TODO: bump
npmand cut new release