This repository has been archived by the owner on May 10, 2024. It is now read-only.
Deployment docs #212
Open
Deployment docs #212
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
@tazarov can you take a look here? |
tazarov
reviewed
Mar 15, 2024
There was a problem hiding this comment.
@jeffchuber, this looks fine, but I wonder if it makes DX better or worse by having to create/manage additional volume as opposed to local dir bind?
| @@ -38,7 +38,8 @@ You can get the Chroma Docker image from [Docker Hub](https://hub.docker.com/r/c | |||
|
|
|||
| ```sh | |||
| docker pull chromadb/chroma | |||
| docker run -p 8000:8000 chromadb/chroma | |||
| docker volume create chroma-data | |||
There was a problem hiding this comment.
@jarqvi, in your experience, why do you think this is better than local dir binding (-v ./chroma-data:/chroma/chroma)? Is it better for developer experience to create a separate volume?
There was a problem hiding this comment.
I usually use volumes to store container data and bind mounts to configure or dynamically change the container.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I feel like this can be useful