-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert to yarn 1 #13
Revert to yarn 1 #13
Conversation
This reverts commit b9d4d11.
AP-3365 Revert from `pnpm`-> yarn 1
As requested by Jarel Fryer. We can just use this workaround for the require issue: storybookjs/storybook#22431 (comment) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small Question. Don't forget to update the readme
"@storybook/addon-docs": "^7.1.0-alpha.34", | ||
"@storybook/addons": "^7.1.0-alpha.34", | ||
"@storybook/api": "^7.1.0-alpha.34", | ||
"@storybook/components": "^7.1.0-alpha.34", | ||
"@storybook/theming": "^7.1.0-alpha.34" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we add these as resolutions as well?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't see why that would be necessary. Perhaps someone can enlighten me. It seems to work without them.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm also unsure why the react resolutions were there.
For consistency with other apps team projects
📦 Published PR as canary version:
0.0.4--canary.13.9d0624d.0
✨ Test out this PR locally via:
npm install @chromaui/addon-visual-tests@0.0.4--canary.13.9d0624d.0 # or yarn add @chromaui/addon-visual-tests@0.0.4--canary.13.9d0624d.0