Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert to yarn 1 #13

Merged
merged 6 commits into from
Jul 21, 2023
Merged

Revert to yarn 1 #13

merged 6 commits into from
Jul 21, 2023

Conversation

tmeasday
Copy link
Member

@tmeasday tmeasday commented Jul 14, 2023

For consistency with other apps team projects

📦 Published PR as canary version: 0.0.4--canary.13.9d0624d.0

✨ Test out this PR locally via:

npm install @chromaui/addon-visual-tests@0.0.4--canary.13.9d0624d.0
# or 
yarn add @chromaui/addon-visual-tests@0.0.4--canary.13.9d0624d.0

@linear
Copy link

linear bot commented Jul 14, 2023

AP-3365 Revert from `pnpm`-> yarn 1

As requested by Jarel Fryer.

We can just use this workaround for the require issue: storybookjs/storybook#22431 (comment)

Copy link
Member

@thafryer thafryer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small Question. Don't forget to update the readme

Comment on lines -136 to -143
"@storybook/addon-docs": "^7.1.0-alpha.34",
"@storybook/addons": "^7.1.0-alpha.34",
"@storybook/api": "^7.1.0-alpha.34",
"@storybook/components": "^7.1.0-alpha.34",
"@storybook/theming": "^7.1.0-alpha.34"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we add these as resolutions as well?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see why that would be necessary. Perhaps someone can enlighten me. It seems to work without them.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm also unsure why the react resolutions were there.

@tmeasday tmeasday merged commit 702b9d3 into main Jul 21, 2023
@tmeasday tmeasday deleted the tom/ap-3365-revert-from-pnpm-yarn-1 branch July 21, 2023 02:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants