Merge pull request #1051 from chromaui/cody/cap-2225-enable-unicornno…

…-array-callback-reference

Enable `unicorn/no-array-callback-reference` ESLint rule

bin-src/trim-stats-file.ts

@@ -23,9 +23,11 @@ export async function main([statsFile = './storybook-static/preview-stats.json']
   try {
     const stats = await readStatsFile(statsFile);
     const trimmedModules = stats.modules
-      .filter(isUserCode)
+      .filter((module) => isUserCode(module))
       .map(({ id, name, modules, reasons }) => {
-        const trimmedReasons = dedupe(reasons.filter(isUserCode).map((r) => r.moduleName))
+        const trimmedReasons = dedupe(
+          reasons.filter((reason) => isUserCode(reason)).map((r) => r.moduleName)
+        )
           .filter((n) => n !== name)
           .map((moduleName) => ({ moduleName }));
         return {

eslint.config.mjs

@@ -139,7 +139,6 @@ export default [
       'unicorn/no-null': 'off',
       'unicorn/better-regex': 'off',
       'unicorn/no-array-reduce': 'off',
-      'unicorn/no-array-callback-reference': 'off',
       'unicorn/prefer-module': 'off',
       'unicorn/prefer-spread': 'off',
     },

node-src/lib/e2e.ts

@@ -24,7 +24,7 @@ const parseNexec = ((agent, args) => {
   };
 
   const command = map[agent];
-  return command.replace('{0}', args.map(quote).join(' ')).trim();
+  return command.replace('{0}', args.map((c) => quote(c)).join(' ')).trim();
 }) as Runner;
 
 export async function getE2EBuildCommand(

node-src/lib/findChangedPackageFiles.ts

@@ -83,7 +83,7 @@ export const findChangedPackageFiles = async (
 ) => {
   const changedManifestFiles = await Promise.all(
     packageMetadataChanges.map(({ changedFiles, commit }) => {
-      const changedManifestFiles = changedFiles.filter(isPackageMetadataFile);
+      const changedManifestFiles = changedFiles.filter((f) => isPackageMetadataFile(f));
       if (!changedManifestFiles) return [];
       return getManifestFilesWithChangedDependencies(changedManifestFiles, commit);
     })

node-src/lib/getDependentStoryFiles.ts

@@ -113,7 +113,7 @@ export async function getDependentStoryFiles(
       `/virtual:/@storybook/builder-vite/vite-app.js`,
       // rspack builder
       `./node_modules/.cache/storybook/default/dev-server/storybook-stories.js`,
-    ].map(normalize)
+    ].map((file) => normalize(file))
   );
 
   const modulesByName = new Map<NormalizedName, Module>();
@@ -192,7 +192,7 @@ export async function getDependentStoryFiles(
     // Convert dependency names into their corresponding files which occur in the stats file.
     ...changedDependencies.flatMap((packageName) => nodeModules.get(packageName) || []),
     ...changedFiles,
-  ].filter(untrace);
+  ].filter((file) => untrace(file));
   const tracedPaths = new Set<string>();
   const affectedModuleIds = new Set<string | number>();
   const checkedIds = {};
@@ -211,14 +211,14 @@ export async function getDependentStoryFiles(
     bailReason: undefined,
   };
 
-  const changedPackageLockFiles = tracedFiles.filter(isPackageLockFile);
+  const changedPackageLockFiles = tracedFiles.filter((file) => isPackageLockFile(file));
 
   if (nodeModules.size === 0 && changedDependencies.length > 0) {
     // If we didn't find any node_modules in the stats file, it's probably incomplete and we can't
     // trace changed dependencies, so we bail just in case.
     ctx.turboSnap.bailReason = {
       changedPackageFiles: ctx.git.changedFiles
-        .filter(isPackageManifestFile)
+        .filter((file) => isPackageManifestFile(file))
         .concat(changedPackageLockFiles),
     };
   }
@@ -248,7 +248,7 @@ export async function getDependentStoryFiles(
     // Queue this id for tracing
     toCheck.push([id, [...tracePath, id]]);
 
-    if (reasonsById.get(id).some(isCsfGlob)) {
+    if (reasonsById.get(id).some((reason) => isCsfGlob(reason))) {
       affectedModuleIds.add(id);
       tracedPaths.add([...tracePath, id].map((pid) => namesById.get(pid)).join('\n'));
     }
@@ -267,7 +267,7 @@ export async function getDependentStoryFiles(
     checkedIds[id] = true;
     reasonsById
       .get(id)
-      .filter(untrace)
+      .filter((file) => untrace(file))
       .map((reason) => traceName(reason, tracePath));
   }
   const affectedModules = Object.fromEntries(

node-src/lib/getStorybookMetadata.ts

@@ -24,15 +24,15 @@ export const resolvePackageJson = (pkg: string) => {
 
 const findDependency = (
   { dependencies, devDependencies, peerDependencies },
-  predicate: Parameters<typeof Array.prototype.find>[0]
+  predicate: (key: string) => string
 ) => [
-  Object.entries(dependencies || {}).find(predicate),
-  Object.entries(devDependencies || {}).find(predicate),
-  Object.entries(peerDependencies || {}).find(predicate),
+  Object.keys(dependencies || {}).find((dependency) => predicate(dependency)),
+  Object.keys(devDependencies || {}).find((dependency) => predicate(dependency)),
+  Object.keys(peerDependencies || {}).find((dependency) => predicate(dependency)),
 ];
 
 const getDependencyInfo = ({ packageJson, log }, dependencyMap: Record<string, string>) => {
-  const [dep, devDep, peerDep] = findDependency(packageJson, ([key]) => dependencyMap[key]);
+  const [dep, devDep, peerDep] = findDependency(packageJson, (key) => dependencyMap[key]);
   const [pkg, version] = dep || devDep || peerDep || [];
   const dependency = viewLayers[pkg];
 

node-src/lib/promises.ts

@@ -5,7 +5,7 @@ const invert = (promise: Promise<any>) =>
   new Promise<any>((resolve, reject) => promise.then(reject, resolve));
 
 export const raceFulfilled = <T>(promises: Promise<T>[]): Promise<T> =>
-  invert(Promise.all(promises.map(invert)).then((arr) => arr[0]));
+  invert(Promise.all(promises.map((promise) => invert(promise))).then((arr) => arr[0]));
 
 export const timeout = (ms: number) =>
   new Promise((_, rej) => {

node-src/tasks/gitInfo.ts

@@ -199,7 +199,7 @@ export const setGitInfo = async (ctx: Context, task: Task) => {
         ({ build, changedFiles, replacementBuild }) => {
           const metadataFiles = changedFiles
             .filter((f) => !untraced.some((glob) => matchesFile(glob, f)))
-            .filter(isPackageMetadataFile);
+            .filter((f) => isPackageMetadataFile(f));
 
           return metadataFiles.length > 0
             ? [{ changedFiles: metadataFiles, commit: replacementBuild?.commit ?? build.commit }]

node-src/ui/messages/errors/uploadFailed.ts

@@ -4,7 +4,11 @@ import { dedent } from 'ts-dedent';
 import { FileDesc, TargetInfo } from '../../../types';
 import { error as icon } from '../../components/icons';
 
-const encode = (path: string) => path.split('/').map(encodeURIComponent).join('/');
+const encode = (path: string) =>
+  path
+    .split('/')
+    .map((component) => encodeURIComponent(component))
+    .join('/');
 
 export function uploadFailed({ target }: { target: FileDesc & TargetInfo }, debug = false) {
   const diagnosis =

node-src/ui/messages/info/listingStories.ts

@@ -14,7 +14,7 @@ const snapshotRow = ({ spec }: { spec: Spec }) =>
 export default (snapshots: { spec: Spec }[]) =>
   dedent(chalk`
     {bold Listing available stories:}
-    ${snapshots.map(snapshotRow).join('\n')}
+    ${snapshots.map((snapshot) => snapshotRow(snapshot)).join('\n')}
 
     ${info} Use {bold --only-story-names} to run a build for a specific component or story.
     Globs are supported, for example: {bold --only-story-names "${