Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Use --stats-json flag for SB 8.0.0+" #1058

Conversation

jmhobbs
Copy link
Contributor

@jmhobbs jmhobbs commented Sep 24, 2024

Reverts #1049

📦 Published PR as canary version: 11.10.5--canary.1058.11018508168.0

✨ Test out this PR locally via:

npm install chromatic@11.10.5--canary.1058.11018508168.0
# or 
yarn add chromatic@11.10.5--canary.1058.11018508168.0

@jmhobbs jmhobbs requested a review from a team September 24, 2024 16:52
@jmhobbs jmhobbs self-assigned this Sep 24, 2024
Copy link

linear bot commented Sep 24, 2024

Copy link
Contributor

📦 Package Size: 4180 KB

Copy link

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
-0.05% (target: -1.00%) 83.33% (target: 80.00%)
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (2338808) 8343 4488 53.79%
Head commit (805eee1) 8336 (-7) 4480 (-8) 53.74% (-0.05%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#1058) 6 5 83.33%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

@jmhobbs jmhobbs added release Auto: Create a `latest` release when merged patch Auto: Increment the patch version when merged labels Sep 24, 2024
Copy link
Contributor

@jwir3 jwir3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@jmhobbs jmhobbs added this pull request to the merge queue Sep 24, 2024
Merged via the queue into main with commit 77d4f8f Sep 24, 2024
25 of 26 checks passed
@jmhobbs jmhobbs deleted the revert-1049-jmhobbs/cap-2186-gha-doesnt-recognize-the-flag-stats-json branch September 24, 2024 17:02
@ghengeveld
Copy link
Member

🚀 PR was released in v11.10.4 🚀

@ghengeveld ghengeveld added the released Verdict: This issue/pull request has been released label Sep 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch Auto: Increment the patch version when merged release Auto: Create a `latest` release when merged released Verdict: This issue/pull request has been released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants