Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Track package size over time. #1059

Merged

Conversation

jmhobbs
Copy link
Contributor

@jmhobbs jmhobbs commented Sep 24, 2024

Adds package size tracking against main via Upstash.

Workflow

  • Build CLI
  • Get size of dist
  • Set key for the current SHA in Upstash
  • Get the current SHA of main
  • Get the value of the main SHA from Upstash
  • Update/Set comment with size of this PR, and the +/- from main

The main workflow just does the update to Upstash.


📦 Published PR as canary version: 11.11.1--canary.1059.11113603111.0

✨ Test out this PR locally via:

npm install chromatic@11.11.1--canary.1059.11113603111.0
# or 
yarn add chromatic@11.11.1--canary.1059.11113603111.0

@jmhobbs jmhobbs self-assigned this Sep 24, 2024
@jmhobbs jmhobbs added patch Auto: Increment the patch version when merged skip-release Auto: Preserve the current version when merged labels Sep 24, 2024
Copy link

codacy-production bot commented Sep 24, 2024

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
Report missing for 06d1cc21 (target: 80.00%)
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (06d1cc2) Report Missing Report Missing Report Missing
Head commit (d70d741) 8336 4480 53.74%

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#1059) 0 0 ∅ (not applicable)

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

Footnotes

  1. Codacy didn't receive coverage data for the commit, or there was an error processing the received data. Check your integration for errors and validate that your coverage setup is correct.

@jmhobbs jmhobbs force-pushed the jmhobbs/cap-2219-add-service-for-size-storage-and-lookup branch 4 times, most recently from c3710b7 to b8d236a Compare September 24, 2024 20:21
Copy link
Contributor

github-actions bot commented Sep 24, 2024

📦 Package Size: 4180 KB
✅ Compared to main: 0 KB 06d1cc2 (4180 KB)

@jmhobbs jmhobbs force-pushed the jmhobbs/cap-2219-add-service-for-size-storage-and-lookup branch from b8d236a to d70d741 Compare September 24, 2024 20:25
@jmhobbs
Copy link
Contributor Author

jmhobbs commented Sep 24, 2024

Smaller package comment example
Screenshot 2024-09-24 at 3 28 24 PM

Larger package warning comment example
Screenshot 2024-09-24 at 3 26 46 PM

@jmhobbs jmhobbs requested a review from a team September 24, 2024 20:31
@jmhobbs jmhobbs marked this pull request as ready for review September 24, 2024 20:31
Copy link
Contributor

@jwir3 jwir3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With my finger on the trigger, I run dot-slash-configure
Yo, this package is big, but MY package is bigger.

@jmhobbs jmhobbs added this pull request to the merge queue Sep 24, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Sep 24, 2024
@jmhobbs jmhobbs added this pull request to the merge queue Sep 24, 2024
Merged via the queue into main with commit 335d795 Sep 24, 2024
22 checks passed
@jmhobbs jmhobbs deleted the jmhobbs/cap-2219-add-service-for-size-storage-and-lookup branch September 24, 2024 21:19
@ghengeveld
Copy link
Member

🚀 PR was released in v11.11.0 🚀

@ghengeveld ghengeveld added the released Verdict: This issue/pull request has been released label Sep 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch Auto: Increment the patch version when merged released Verdict: This issue/pull request has been released skip-release Auto: Preserve the current version when merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants