Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable unicorn/prefer-module ESLint rule #1061

Merged
merged 2 commits into from
Sep 30, 2024

Conversation

codykaup
Copy link
Contributor

@codykaup codykaup commented Sep 27, 2024

Simply enables our unicorn/prefer-module ESLint rule and fixes any errors that appear.

Unfortunately, import.meta.dirname was unavailable so you have to grab it from import.meta.url 😞

📦 Published PR as canary version: 11.11.1--canary.1061.11113701181.0

✨ Test out this PR locally via:

npm install chromatic@11.11.1--canary.1061.11113701181.0
# or 
yarn add chromatic@11.11.1--canary.1061.11113701181.0

@codykaup codykaup added minor Auto: Increment the minor version when merged skip-release Auto: Preserve the current version when merged labels Sep 27, 2024
@codykaup codykaup self-assigned this Sep 27, 2024
Copy link

codacy-production bot commented Sep 27, 2024

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
-0.05% (target: -1.00%) 0.00% (target: 80.00%)
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (aa83825) 8399 4543 54.09%
Head commit (9fc7574) 8407 (+8) 4543 (+0) 54.04% (-0.05%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#1061) 14 0 0.00%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

Copy link
Contributor

github-actions bot commented Sep 27, 2024

📦 Package Size: 4160 KB
✅ Compared to main: -20 KB aa83825 (4180 KB)

@codykaup codykaup requested a review from a team September 27, 2024 21:51
@codykaup codykaup added patch Auto: Increment the patch version when merged and removed minor Auto: Increment the minor version when merged labels Sep 30, 2024
@codykaup codykaup force-pushed the cody/cap-2227-enable-unicornprefer-module branch from 59745ce to 9fc7574 Compare September 30, 2024 20:33
@codykaup codykaup added this pull request to the merge queue Sep 30, 2024
Merged via the queue into main with commit 83a81fe Sep 30, 2024
19 of 20 checks passed
@codykaup codykaup deleted the cody/cap-2227-enable-unicornprefer-module branch September 30, 2024 20:41
@codykaup codykaup mentioned this pull request Oct 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch Auto: Increment the patch version when merged skip-release Auto: Preserve the current version when merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants