-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable unicorn/filename-case
ESLint rule
#1062
Conversation
Coverage summary from CodacySee diff coverage on Codacy
Coverage variation details
Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: Diff coverage details
Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: See your quality gate settingsΒ Β Β Β Change summary preferencesCodacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more |
π¦ Package Size: 4160 KB |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm a little on the fence about the subcommand files. There is something nice about the symmetry of trim-stats-file
being found in trim-stats-file.ts
instead of trimStatsFile.ts
@jmhobbs So here's a funny thing... I'm actually the opposite π . To me, the filenames should all match and my brain translates the command name into the camel case for the filename when I go to search for it. |
4ad0f95
to
e0cc85f
Compare
Fair enough! Probably better to stick to the convention we have everywhere instead of making exceptions. |
Simply enables our
unicorn/filename-case
ESLint rule and fixes any errors that appear.π¦ Published PR as canary version:
11.11.1--canary.1062.11128106915.0
β¨ Test out this PR locally via:
npm install chromatic@11.11.1--canary.1062.11128106915.0 # or yarn add chromatic@11.11.1--canary.1062.11128106915.0