Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable unicorn/filename-case ESLint rule #1062

Merged
merged 4 commits into from
Oct 1, 2024

Conversation

codykaup
Copy link
Contributor

@codykaup codykaup commented Sep 27, 2024

Simply enables our unicorn/filename-case ESLint rule and fixes any errors that appear.

πŸ“¦ Published PR as canary version: 11.11.1--canary.1062.11128106915.0

✨ Test out this PR locally via:

npm install chromatic@11.11.1--canary.1062.11128106915.0
# or 
yarn add chromatic@11.11.1--canary.1062.11128106915.0

@codykaup codykaup added minor Auto: Increment the minor version when merged skip-release Auto: Preserve the current version when merged labels Sep 27, 2024
@codykaup codykaup self-assigned this Sep 27, 2024
Copy link

codacy-production bot commented Sep 27, 2024

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
βœ… +0.00% (target: -1.00%) ❌ 66.67% (target: 80.00%)
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (c97b1b9) 8399 4513 53.73%
Head commit (e0cc85f) 8399 (+0) 4513 (+0) 53.73% (+0.00%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#1062) 15 10 66.67%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settingsΒ Β Β Β Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

@codykaup codykaup requested a review from a team September 27, 2024 22:37
Copy link
Contributor

github-actions bot commented Sep 27, 2024

πŸ“¦ Package Size: 4160 KB
βœ… Compared to main: 0 KB c97b1b9 (4160 KB)

Copy link
Contributor

@jmhobbs jmhobbs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm a little on the fence about the subcommand files. There is something nice about the symmetry of trim-stats-file being found in trim-stats-file.ts instead of trimStatsFile.ts

@codykaup
Copy link
Contributor Author

I'm a little on the fence about the subcommand files. There is something nice about the symmetry of trim-stats-file being found in trim-stats-file.ts instead of trimStatsFile.ts

@jmhobbs So here's a funny thing... I'm actually the opposite πŸ˜…. To me, the filenames should all match and my brain translates the command name into the camel case for the filename when I go to search for it.

@codykaup codykaup force-pushed the cody/cap-2259-enable-unicornfilename-case branch from 4ad0f95 to e0cc85f Compare October 1, 2024 14:56
@codykaup codykaup added patch Auto: Increment the patch version when merged and removed minor Auto: Increment the minor version when merged labels Oct 1, 2024
@jmhobbs
Copy link
Contributor

jmhobbs commented Oct 1, 2024

@jmhobbs So here's a funny thing... I'm actually the opposite πŸ˜…. To me, the filenames should all match and my brain translates the command name into the camel case for the filename when I go to search for it.

Fair enough! Probably better to stick to the convention we have everywhere instead of making exceptions. :shipit:

@codykaup codykaup added this pull request to the merge queue Oct 1, 2024
Merged via the queue into main with commit 6fe6065 Oct 1, 2024
23 of 24 checks passed
@codykaup codykaup deleted the cody/cap-2259-enable-unicornfilename-case branch October 1, 2024 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch Auto: Increment the patch version when merged skip-release Auto: Preserve the current version when merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants