Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable @typescript-eslint/no-floating-promises ESLint rule #1065

Merged

Conversation

codykaup
Copy link
Contributor

@codykaup codykaup commented Sep 30, 2024

I thought we had some of these sitting around but I guess I was wrong... therefore, we can simply enable our @typescript-eslint/no-floating-promises rule with no changes!

📦 Published PR as canary version: 11.11.1--canary.1065.11113603593.0

✨ Test out this PR locally via:

npm install chromatic@11.11.1--canary.1065.11113603593.0
# or 
yarn add chromatic@11.11.1--canary.1065.11113603593.0

@codykaup codykaup added minor Auto: Increment the minor version when merged skip-release Auto: Preserve the current version when merged labels Sep 30, 2024
@codykaup codykaup self-assigned this Sep 30, 2024
Copy link

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
+0.00% (target: -1.00%) (target: 80.00%)
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (38a7b49) 8348 4485 53.73%
Head commit (794c543) 8348 (+0) 4485 (+0) 53.73% (+0.00%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#1065) 0 0 ∅ (not applicable)

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

@codykaup codykaup requested a review from a team September 30, 2024 14:57
Copy link
Contributor

📦 Package Size: 4180 KB
✅ Compared to main: 0 KB 38a7b49 (4180 KB)

@codykaup codykaup added this pull request to the merge queue Sep 30, 2024
Merged via the queue into main with commit 2f6a0a4 Sep 30, 2024
26 checks passed
@codykaup codykaup deleted the cody/cap-2261-enable-typescript-eslintno-floating-promises branch September 30, 2024 15:42
@ghengeveld
Copy link
Member

🚀 PR was released in v11.11.0 🚀

@ghengeveld ghengeveld added the released Verdict: This issue/pull request has been released label Sep 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
minor Auto: Increment the minor version when merged released Verdict: This issue/pull request has been released skip-release Auto: Preserve the current version when merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants