Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle ENOENT for bun as well as Node #1108

Conversation

jmhobbs
Copy link
Contributor

@jmhobbs jmhobbs commented Oct 22, 2024

📦 Published PR as canary version: 11.16.2--canary.1108.11523272113.0

✨ Test out this PR locally via:

npm install chromatic@11.16.2--canary.1108.11523272113.0
# or 
yarn add chromatic@11.16.2--canary.1108.11523272113.0

@jmhobbs jmhobbs requested a review from a team October 22, 2024 22:07
@jmhobbs jmhobbs self-assigned this Oct 22, 2024
Copy link
Contributor

github-actions bot commented Oct 22, 2024

📦 Package Size: 5380 KB

Copy link

codacy-production bot commented Oct 22, 2024

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
Report missing for 8dbc03c1 100.00% (target: 80.00%)
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (8dbc03c) Report Missing Report Missing Report Missing
Head commit (7aeeafb) 7116 4839 68.00%

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#1108) 4 4 100.00%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

Footnotes

  1. Codacy didn't receive coverage data for the commit, or there was an error processing the received data. Check your integration for errors and validate that your coverage setup is correct.

@jmhobbs jmhobbs force-pushed the jmhobbs/cap-2338-investigate-missing-file-error-in-gitlab-ci-build-for-bell branch from d581034 to 499812c Compare October 25, 2024 16:40
@jmhobbs jmhobbs changed the title Catch errors thrown reading Storybook log file. Handle ENOENT for bun as well as Node Oct 25, 2024
@jmhobbs jmhobbs force-pushed the jmhobbs/cap-2338-investigate-missing-file-error-in-gitlab-ci-build-for-bell branch from 499812c to 7aeeafb Compare October 25, 2024 16:40
@jmhobbs jmhobbs added patch Auto: Increment the patch version when merged skip-release Auto: Preserve the current version when merged release Auto: Create a `latest` release when merged and removed skip-release Auto: Preserve the current version when merged labels Oct 25, 2024
@jmhobbs jmhobbs marked this pull request as ready for review October 25, 2024 16:41
@jmhobbs jmhobbs requested a review from codykaup October 25, 2024 16:41
@jmhobbs jmhobbs added this pull request to the merge queue Oct 25, 2024
Merged via the queue into main with commit 710fdb7 Oct 25, 2024
28 of 30 checks passed
@jmhobbs jmhobbs deleted the jmhobbs/cap-2338-investigate-missing-file-error-in-gitlab-ci-build-for-bell branch October 25, 2024 18:08
@chromatic-ci-bot
Copy link
Collaborator

🚀 PR was released in v11.16.1 🚀

@chromatic-ci-bot chromatic-ci-bot added the released Verdict: This issue/pull request has been released label Oct 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch Auto: Increment the patch version when merged release Auto: Create a `latest` release when merged released Verdict: This issue/pull request has been released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants