Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Account for rsbuild stats JSON output and multiple locations #1110

Merged
merged 1 commit into from
Nov 4, 2024

Conversation

codykaup
Copy link
Contributor

@codykaup codykaup commented Oct 28, 2024

At some point the rsbuild cache location changed which broke Turbosnap. Simply adding the new location to our list fixes that issue.

I also noticed the stats output is slightly different than Webpack/Vite so we lean on resolvedModule (which only exists in rsbuild) but fallback to moduleName when it doesn't exist.

Both of these changes allow rsbuild to work on the newer versions!

Note: We've been doing some external testing with the canary and things are working great!

📦 Published PR as canary version: 11.16.6--canary.1110.11673164256.0

✨ Test out this PR locally via:

npm install chromatic@11.16.6--canary.1110.11673164256.0
# or 
yarn add chromatic@11.16.6--canary.1110.11673164256.0

@codykaup codykaup self-assigned this Oct 28, 2024
@codykaup codykaup added release Auto: Create a `latest` release when merged patch Auto: Increment the patch version when merged labels Oct 28, 2024
Copy link
Contributor

github-actions bot commented Oct 28, 2024

📦 Package Size: 5380 KB

Copy link

codacy-production bot commented Oct 29, 2024

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
Report missing for ce30b2b1 100.00% (target: 80.00%)
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (ce30b2b) Report Missing Report Missing Report Missing
Head commit (c3398c3) 7122 4845 68.03%

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#1110) 7 7 100.00%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

Footnotes

  1. Codacy didn't receive coverage data for the commit, or there was an error processing the received data. Check your integration for errors and validate that your coverage setup is correct.

@codykaup codykaup requested a review from a team November 4, 2024 17:51
@codykaup codykaup marked this pull request as ready for review November 4, 2024 17:52
@codykaup codykaup added this pull request to the merge queue Nov 4, 2024
@codykaup codykaup removed this pull request from the merge queue due to a manual request Nov 4, 2024
@codykaup codykaup added this pull request to the merge queue Nov 4, 2024
Merged via the queue into main with commit d57bc69 Nov 4, 2024
22 checks passed
@codykaup codykaup deleted the cody/turbosnap-with-rsbuild branch November 4, 2024 21:38
@chromatic-ci-bot
Copy link
Collaborator

🚀 PR was released in v11.16.5 🚀

@chromatic-ci-bot chromatic-ci-bot added the released Verdict: This issue/pull request has been released label Nov 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch Auto: Increment the patch version when merged release Auto: Create a `latest` release when merged released Verdict: This issue/pull request has been released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants