Selecting specific element also applies pseudo state to all its descendants alternate #85
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JonathanKolnik
force-pushed
the
56-selecting-specific-element-also-applies-pseudostate-to-all-its-descendants-alternate
branch
from
1620751 to
51e6b50
Compare
ghengeveld
approved these changes
Aug 21, 2023
JonathanKolnik
deleted the
56-selecting-specific-element-also-applies-pseudostate-to-all-its-descendants-alternate
branch
|
🚀 PR was released in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📦 Published PR as canary version:
2.1.1--canary.85.0bc3584.0✨ Test out this PR locally via:
npm install storybook-addon-pseudo-states@2.1.1--canary.85.0bc3584.0 # or yarn add storybook-addon-pseudo-states@2.1.1--canary.85.0bc3584.0Related to #56
This PR modifies withPseudoState at the step of applying classes to a root element.
Before it would apply the same class,
.pseudo-[state], to any element. This meant there was no way to distinguish whether or not this class was written due to a booleanpseudo: { hover: true, }or a specific selectorpseudo: { hover: ["#foo"], }Now that there is this distinction in place, a pseudo effect that is applied to a specific selector will no longer unintentionally apply to that selector's descendants.