Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1.4] Fix do not open "What's new" page on startup launch #350

Merged
merged 1 commit into from
Mar 2, 2022

Conversation

edgardmessias
Copy link
Contributor

This is a simple startup argument to avoid openning a "What's new" page on each launch

@enricodias
Copy link
Member

Wouldn't --no-startup-window prevent any window to be opened during startup? I guess the proper way to disable only the "what's new" page would be --disable-features=ChromeWhatsNewUI

@edgardmessias
Copy link
Contributor Author

Hello. Thanks @enricodias , I will do some tests abou this flag.

I extracted that option from playwright project

@edgardmessias
Copy link
Contributor Author

@enricodias , I updated to use --disable-features=ChromeWhatsNewUI and work like a charm

@enricodias
Copy link
Member

I saw it.
The about:blank as the default page may break things is someone is already using a lib expecting it to open the default page. We could add just the --disable-features=ChromeWhatsNewUI as a bug fix directly to v1.4.

@edgardmessias edgardmessias changed the base branch from 1.5 to 1.4 March 2, 2022 16:14
@edgardmessias
Copy link
Contributor Author

Done

@edgardmessias edgardmessias changed the title Do not open "What's new" page on startup launch Fix do not open "What's new" page on startup launch Mar 2, 2022
@enricodias enricodias merged commit f1c4712 into chrome-php:1.4 Mar 2, 2022
@jmtalves
Copy link

jmtalves commented Mar 9, 2022

No Work, still given error "Cannot start browser".

When adding "'debugLogger' => 'php://stdout'," , get error ERR_HTTP2_PROTOCOL_ERROR
Line execution: $browserFactory->createBrowser

Google Chrome version: 99.0.4844.51

`PHP Fatal error:  Uncaught HeadlessChromium\Exception\OperationTimedOut: Operation timed out after 30s. in /home/public_html/chrome/src/Exception/OperationTimedOut.php:18
Stack trace:
#0 /home/public_html/chrome/src/Utils.php(64): HeadlessChromium\Exception\OperationTimedOut::createFromTimeout(30000000)
#1 /home/public_html/chrome/src/Browser/BrowserProcess.php(447): HeadlessChromium\Utils::tryWithTimeout(30000000, Object(Generator))
#2 /home/public_html/chrome/src/Browser/BrowserProcess.php(139): HeadlessChromium\Browser\BrowserProcess->waitForStartup(Object(Symfony\Component\Process\Process), 30000000)
#3 /home/public_html/chrome/src/BrowserFactory.php(81): HeadlessChromium\Browser\BrowserProcess->start('google-chrome', Array)
#4 /home/public_html/meta2.php(11): HeadlessChromium\BrowserFactory->createBrowser(Array)
#5 {main}

Next RuntimeException: Cannot start browser in /home/public_html/chro in /home/public_html/chrome/src/Browser/BrowserProcess.php on line 449`

@enricodias
Copy link
Member

@jmtalves I don't think this error is related to this PR.

@jmtalves
Copy link

problem is related to permissions on the 'public_html' folder, I didn't have the right permissions

Thanks

@GrahamCampbell GrahamCampbell changed the title Fix do not open "What's new" page on startup launch [1.4] Fix do not open "What's new" page on startup launch Mar 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants