Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set custom user agent string for hstspreload #121

Merged
merged 4 commits into from
Feb 1, 2022
Merged

Conversation

devonobrien
Copy link
Collaborator

To stop hstspreload from being blocked by CDN and others' user agent filtering (#107), this CL changes the UA string from go's default string to hsts-preload-bot. I tested this on a branch for several updates and we have confirmation that some folk were able to allowlist this UA string to avoid the issue with the live queries being blocked.

Copy link
Collaborator

@lgarron lgarron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, I guess we've mulled over this a long time and learned about limitations of not setting a custom UA. Let's hope it doesn't paint us into a corner..

Nit: I would go for hstspreload-bot, to match the domain and project names.

redirects.go Outdated Show resolved Hide resolved
response.go Outdated Show resolved Hide resolved
devonobrien and others added 2 commits January 31, 2022 15:46
Co-authored-by: Lucas Garron <code@garron.net>
Co-authored-by: Lucas Garron <code@garron.net>
@devonobrien devonobrien merged commit 2f7d9e6 into master Feb 1, 2022
@lgarron
Copy link
Collaborator

lgarron commented Feb 1, 2022

By the way, I know at least Mozilla was doing their own liveness checks — have you perchance talked to other browser vendors about using the same UA?

@lgarron lgarron deleted the fixUserAgentString branch February 1, 2022 01:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants