Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a clang 18 bot and move non-pinned bots to 18 #330

Merged
merged 1 commit into from
Aug 24, 2023

Conversation

danakj
Copy link
Collaborator

@danakj danakj commented Aug 23, 2023

No description provided.

@danakj
Copy link
Collaborator Author

danakj commented Aug 23, 2023

This will require a roll of fmtlib after fmtlib/fmt#3607 is addressed.

@danakj danakj changed the title Add a clang 18 bot @danakj Add a clang 18 bot and move non-pinned bots to 18 Aug 23, 2023
@danakj danakj changed the title @danakj Add a clang 18 bot and move non-pinned bots to 18 Add a clang 18 bot and move non-pinned bots to 18 Aug 23, 2023
@danakj danakj force-pushed the clang-18 branch 3 times, most recently from 2d0843d to 4f8e427 Compare August 23, 2023 22:21
@danakj
Copy link
Collaborator Author

danakj commented Aug 24, 2023

LLVM reverted the change that enabled -Wdeprecated-literal-operator by default for now.

commit 0d9919d362a7a70b2a7970861d897ecc47ec9e4d
Author: Reid Kleckner <rnk@google.com>
Date:   Tue Aug 22 18:10:41 2023 -0700

    Revert "[Clang] CWG1473: do not err on the lack of space after operator"""

    This reverts commit f2583f3acf596cc545c8c0e3cb28e712f4ebf21b.

    There is a large body of non-conforming C-like code using format strings
    like this:

      #define PRIuS "zu"
      void h(size_t foo, size_t bar) {
        printf("foo is %"PRIuS", bar is %"PRIuS, foo, bar);
      }

    Rejecting this code would be very disruptive. We could decide to do
    that, but it's sufficiently disruptive that I think it requires
    gathering more community consensus with an RFC, and Aaron indicated [1]
    it's OK to revert for now so continuous testing systems can see past
    this issue while we decide what to do.

    [1] https://reviews.llvm.org/D153156#4607717

@danakj danakj merged commit 8be259f into chromium:main Aug 24, 2023
12 of 15 checks passed
@danakj danakj deleted the clang-18 branch August 24, 2023 03:45
@danakj danakj added the build CI / trybots / build system label Sep 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build CI / trybots / build system
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant