Revert unretained dangling ptr detector crash by default (fixes #3693)

chromiumembedded · May 6, 2024 · 69ce47a · 69ce47a
1 parent 0580f93
commit 69ce47a
Show file tree

Hide file tree

Showing 2 changed files with 20 additions and 0 deletions.
diff --git a/patch/patch.cfg b/patch/patch.cfg
@@ -801,5 +801,12 @@ patches = [
     # Reverts
     # https://chromium-review.googlesource.com/c/chromium/src/+/5454331
     'name': 'win_partition_freelist_entry_336007395'
+  },
+  {
+    # Revert unretained dangling ptr detector crash by default.
+    # https://github.com/chromiumembedded/cef/issues/3693
+    # Reverts
+    # https://chromium-review.googlesource.com/c/chromium/src/+/5351597
+    'name': 'base_allocator_unretained_dangling_ptr_5351597'
   }
 ]
diff --git a/patch/patches/base_allocator_unretained_dangling_ptr_5351597.patch b/patch/patches/base_allocator_unretained_dangling_ptr_5351597.patch
@@ -0,0 +1,13 @@
+diff --git base/allocator/partition_alloc_features.cc base/allocator/partition_alloc_features.cc
+index a2616fced0f5b..cacd41b0ffa23 100644
+--- base/allocator/partition_alloc_features.cc
++++ base/allocator/partition_alloc_features.cc
+@@ -36,7 +36,7 @@ const base::FeatureParam<UnretainedDanglingPtrMode>
+     kUnretainedDanglingPtrModeParam = {
+         &kPartitionAllocUnretainedDanglingPtr,
+         "mode",
+-        UnretainedDanglingPtrMode::kCrash,
++        UnretainedDanglingPtrMode::kDumpWithoutCrashing,
+         &kUnretainedDanglingPtrModeOption,
+ };
+