Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The test added in #1077 is pretty much guaranteed to cause trouble.
We don't know if any arbitrary
DateTime<Local>
will exist, such as2022-11-06T01:02:60
in that test. It may fall in a DST transition and not exist or be ambiguous.The fix for #866 in #1064 took this into account, and #1077 added the failure mode right back 😄.
Fixes #1236.