Don't have oldtime feature enabled by default #1241
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As this feature pulls in a dependency on time 0.1 which fail a security audit, it should not be included as a default feature. The corresponding Rust advisory can be found here: https://rustsec.org/advisories/RUSTSEC-2020-0071
Codecov Report
@@ Coverage Diff @@
## 0.4.x #1241 +/- ##
=======================================
Coverage 85.83% 85.83%
=======================================
Files 37 37
Lines 13516 13516
=======================================
Hits 11601 11601
Misses 1915 1915 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
See #1095 for our current proposed solution to this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Having the oldtime feature enabled by default causes packages depending on this to fail a security audit if they leave default features on due to the dependency on time 0.1. Furthermore, the documentation on docs.rs and crates.io indicate that this is an optional and non-default feature. This PR brings the code in-sync with the documentation and also fixes a misspelling of that feature. It can still be enabled for those that need it and are able to ignore the audit.
Further background on this, it looks like this features was dropped on the main branch about a year ago, however, from what I gather, that branch will not be ready for a release any time soon so this is an interim measure until then.