0.5.x: Rename NaiveDate::*_opt methods
#1436
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pitdicker
changed the title
NaiveDate::*_opt methodsNaiveDate::*_opt methods
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## 0.5.x #1436 +/- ##
==========================================
- Coverage 94.19% 94.15% -0.05%
==========================================
Files 37 37
Lines 16821 16696 -125
==========================================
- Hits 15845 15720 -125
Misses 976 976 ☔ View full report in Codecov by Sentry. |
pitdicker
force-pushed
the
rename_opt
branch
from
8aeee93 to
5fcc50f
Compare
pitdicker
force-pushed
the
rename_opt
branch
from
5fcc50f to
f254968
Compare
Zomtir
approved these changes
Feb 15, 2024
djc
approved these changes
Feb 16, 2024
This was referenced Feb 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This continues the renaming op all
_optmethods after the removal of their deprecated panicking variants in #1394. Only theNaiveDatetype was left out of that PR. Turns out for the best, as the find-and-replace touches ca. 1000 lines.The first three commits are a cosmetic fix for some tests that I would like to backport to the main branch in a later PR (I'm collecting a couple).
The last two commits remove 4 lines that mentioned removed
*_optmethods in comments that slipped through in #1394 and the last merge of main.