Convert checked_(add|sub)_signed to return Result
#1514
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pitdicker
force-pushed
the
convert_checked_add
branch
from
c904446 to
7b05323
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 0.5.x #1514 +/- ##
==========================================
- Coverage 94.01% 94.01% -0.01%
==========================================
Files 37 37
Lines 16839 16814 -25
==========================================
- Hits 15832 15807 -25
Misses 1007 1007 ☔ View full report in Codecov by Sentry. |
djc
approved these changes
Mar 14, 2024
pitdicker
force-pushed
the
convert_checked_add
branch
from
7b05323 to
7b89ed7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Convert
NaiveDate::{checked_add_signed, checked_sub_signed}andNaiveDateTime::{checked_add_signed, checked_sub_signed, checked_add_offset, checked_sub_offset}.