Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clippy #1634

Merged
merged 2 commits into from
Nov 29, 2024
Merged

Clippy #1634

merged 2 commits into from
Nov 29, 2024

Conversation

djc
Copy link
Member

@djc djc commented Nov 29, 2024

No description provided.

@djc djc requested a review from pitdicker November 29, 2024 09:43
pitdicker
pitdicker approved these changes Nov 29, 2024
View reviewed changes
Copy link
Collaborator

@pitdicker pitdicker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good cleanups 👍.
What do we have to do with unicode-ident?

@djc
Copy link
Member Author

djc commented Nov 29, 2024

It's a transitive dependency (via syn I think).

@pitdicker pitdicker merged commit ca8232f into main Nov 29, 2024
31 of 33 checks passed
@pitdicker pitdicker deleted the clippy branch November 29, 2024 13:21
@djc
Copy link
Member Author

djc commented Nov 29, 2024

Not sure what's going on with llvm-cov here...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pitdicker pitdicker pitdicker approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@djc @pitdicker