Fix parsing for zone offset seconds #1639
Open
+44
−14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
djc
commented
Dec 11, 2024
| // mismatching colon expectations | ||
| assert!(parse("Aug 09 2013 23:54:35 -09:00:00", "%b %d %Y %H:%M:%S %::z").is_err()); |
There was a problem hiding this comment.
It seems strange that this errored?
There was a problem hiding this comment.
These tests are just weird, and I had to fix them endless times during rebases of the branches where I fixed this offset parsing bug.
djc
force-pushed
the
parse-offset-seconds
branch
from
71b2047 to
7509f42
Compare
djc
force-pushed
the
parse-offset-seconds
branch
from
7509f42 to
db464fa
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1639 +/- ##
==========================================
- Coverage 91.11% 90.90% -0.21%
==========================================
Files 37 37
Lines 17137 17137
==========================================
- Hits 15614 15579 -35
- Misses 1523 1558 +35 ☔ View full report in Codecov by Sentry. |
|
Sorry, I unfortunately don't have time at the moment 😞. A complete fix with tests for this category of errors is in #1083. |
|
@pitdicker thanks for the quick response, and the pointer! Going to have a look at your PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
%::zis defined as:So it seems like we should support this better?
Fixes #1629.