Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix capitalization #1641

Closed
wants to merge 1 commit into from
Closed

Fix capitalization #1641

wants to merge 1 commit into from

Conversation

dannbbb1
Copy link

Description: Fixed the capitalization of "calendar" to "Calendar" to reflect proper noun formatting.

Copy link

codecov bot commented Dec 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.91%. Comparing base (8b86349) to head (ada091c).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1641      +/-   ##
==========================================
- Coverage   91.11%   90.91%   -0.20%     
==========================================
  Files          37       37              
  Lines       17137    17121      -16     
==========================================
- Hits        15614    15566      -48     
- Misses       1523     1555      +32     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@djc
Copy link
Member

djc commented Dec 11, 2024

I don't see how this is "proper noun formatting". It doesn't seem like an improvement to me.

@dannbbb1
Copy link
Author

Thank you for your feedback! I changed 'calendar' to 'Calendar' because, in the context of the text, it could be a proper noun (for example, in the name of an app or system), and I wanted to follow the appropriate rule. If that's not the case, please let me know.

@djc
Copy link
Member

djc commented Dec 12, 2024

If I search for "gregorian calendar" online, it seems like only pages that use title-casing capitalize Calendar. I don't think that fits here.

@djc djc closed this Dec 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants