Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sub days from 0.4.x v3 #804

Merged
merged 4 commits into from
Aug 30, 2022
Merged

Add sub days from 0.4.x v3 #804

merged 4 commits into from
Aug 30, 2022

Conversation

esheppa
Copy link
Collaborator

@esheppa esheppa commented Aug 30, 2022

Will redo the commit message for this to remove the word "merge"

@djc
Copy link
Member

djc commented Aug 30, 2022

I guess the double merge option is fine -- just seems crappy that GitHub doesn't have a better way to do this.

@esheppa
Copy link
Collaborator Author

esheppa commented Aug 30, 2022

lets hold off for a moment as there are a few other options I can try

@esheppa
Copy link
Collaborator Author

esheppa commented Aug 30, 2022

Actually I guess the only way to meet both requirements:

  • avoid double merge commit
  • maintain some link to the history

Is to not have a protected main branch, and just do one merge commit. But that seems worse than just having double merge commits - so then the choices become:

  • Double merge
  • Double rebase (I've done this as test-main-v3 just to make sure I've tried all the options)

Comparing test-main, test-main-v2 and test-main-v3 I think test-main is the clear winner, as the commits can be tracked back. Alternatively if we want only linear history then test-main-v3 is better, however the only way to track the commits is by message.

@djc
Copy link
Member

djc commented Aug 30, 2022

I think I agree. So is this good to merge?

@esheppa
Copy link
Collaborator Author

esheppa commented Aug 30, 2022

Yes good to go unless we think its worth rewording the merge 0.4.x - Add/Sub days commit message

@djc djc merged commit f0aace9 into main Aug 30, 2022
@djc djc deleted the add-sub-days-from-0.4.x-v3 branch August 30, 2022 13:14
@esheppa
Copy link
Collaborator Author

esheppa commented Aug 30, 2022

This is really nice - the 0.4.x branch shows up as exactly 8 commits behind, and 0 ahead, so that makes the double merge definitely the best choice

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants