Move coverage phase to build stages #116
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alumi
approved these changes
Oct 23, 2017
| - stage: deploy | ||
| jdk: oraclejdk8 | ||
| script: skip | ||
| after_success: echo skip |
There was a problem hiding this comment.
Is it because of an upgrade of Travis CI that this line's no longer necessary?
Seems working fine now, but I wonder why we introduced it.
There was a problem hiding this comment.
I added this line to avoid that coverage is executed on deploy stage because top-level after_success is also enabled on build stages. Now coverage stage doesn't use after_success, so this line isn't needed anymore.
|
Merged. Thank you! 👍 |
|
Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The coverage phase accounts for about 2/3 of each build time on CI, and superfluous coverages are currently measured. By moving coverage phase to build stages, the coverage phase will be executed just once and a total of build time will be shortened.