Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add some extensions for FASTA format. #124

Merged
merged 1 commit into from
Dec 14, 2017
Merged

Add some extensions for FASTA format. #124

merged 1 commit into from
Dec 14, 2017

Conversation

alumi
Copy link
Member

@alumi alumi commented Dec 6, 2017

Copy link
Member

@totakke totakke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I didn't know such various extensions exist. But if supporting them, fasta-index in cljam.io.fasta.core should be fixed. FASTA index of some extensions cannot be found.

@codecov
Copy link

codecov bot commented Dec 14, 2017

Codecov Report

Merging #124 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #124      +/-   ##
==========================================
+ Coverage   84.81%   84.82%   +<.01%     
==========================================
  Files          62       62              
  Lines        4196     4197       +1     
  Branches      415      415              
==========================================
+ Hits         3559     3560       +1     
  Misses        222      222              
  Partials      415      415
Impacted Files Coverage Δ
src/cljam/io/util.clj 100% <ø> (ø) ⬆️
src/cljam/io/fasta/core.clj 94.64% <100%> (+0.09%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 649204b...0eadbdd. Read the comment docs.

@alumi
Copy link
Member Author

alumi commented Dec 14, 2017

@totakke Thank you for pointing that. I forgot to check the index.

@totakke totakke merged commit 8485cad into master Dec 14, 2017
@totakke totakke deleted the fix/extensions branch December 14, 2017 06:43
@totakke
Copy link
Member

totakke commented Dec 14, 2017

LGTM. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants