Fix wrong padding of last bases in 2bit writer #127
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #127 +/- ##
=======================================
Coverage 84.82% 84.82%
=======================================
Files 62 62
Lines 4197 4197
Branches 415 415
=======================================
Hits 3560 3560
Misses 222 222
Partials 415 415
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fix a bug that the last 1~3 bases were wrongly padded in the 2bit writer.
Problem
When sequence length is not a multiple of 4, last 1~3 bases are not correctly written.
Cause
In 2bit writer, every 4 bases are packed into a single byte.
The last bases will be packed from MSB and padded with 2r00.
But there was a bug in padding calculation.
Changes
Fix the padding.
Affects
2bit writer.
Tests
lein test :all🆗