-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add FASTQ=>FASTA, SAM=>FASTQ conversions. #129
Conversation
Codecov Report
@@ Coverage Diff @@
## master #129 +/- ##
==========================================
+ Coverage 85.06% 85.25% +0.19%
==========================================
Files 69 69
Lines 4285 4361 +76
Branches 417 420 +3
==========================================
+ Hits 3645 3718 +73
Misses 223 223
- Partials 417 420 +3
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you. I confirmed the behavior. However, I feel confusion about output args of convert
... That doesn't seem intuitive, but what is better way...
Anyway, please remove unused requires.
test/cljam/algo/convert_test.clj
Outdated
[cljam.algo.convert :as convert])) | ||
[cljam.algo.convert :as convert] | ||
[cljam.io.sam :as sam] | ||
[cljam.io.sam.util.sequence :as sam-seq] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cljam.io.sam
and cljam.io.sam.util.sequence
don't seem to be used.
Thanks for the fix. |
Thank you for the helpful discussion! |
Summary
Add converting functions for different contents.
(:name, :sequence, :quality)
=> FASTA/2BIT(:name :sequence)
(:qname, :seq, :qual ...)
=> FASTQ(:name, :sequence, :quality)
samtools fastq
Tests
lein test :all
🆗