Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add FASTQ=>FASTA, SAM=>FASTQ conversions. #129

Merged
merged 4 commits into from
Dec 25, 2017
Merged

Conversation

alumi
Copy link
Member

@alumi alumi commented Dec 22, 2017

Summary

Add converting functions for different contents.

  • FASTQ(:name, :sequence, :quality) => FASTA/2BIT (:name :sequence)
  • SAM/BAM (:qname, :seq, :qual ...) => FASTQ (:name, :sequence, :quality)
    • implemented converting like samtools fastq
    • can output to 1~3 FASTQ files
      • 1 (all primary alignments)
      • 2 (R1 and R2)
      • 3 (R1,R2 and others)

Tests

  • lein test :all 🆗

@codecov
Copy link

codecov bot commented Dec 22, 2017

Codecov Report

Merging #129 into master will increase coverage by 0.19%.
The diff coverage is 94.18%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #129      +/-   ##
==========================================
+ Coverage   85.06%   85.25%   +0.19%     
==========================================
  Files          69       69              
  Lines        4285     4361      +76     
  Branches      417      420       +3     
==========================================
+ Hits         3645     3718      +73     
  Misses        223      223              
- Partials      417      420       +3
Impacted Files Coverage Δ
src/cljam/tools/cli.clj 53.28% <33.33%> (-0.39%) ⬇️
src/cljam/algo/convert.clj 90% <96.38%> (+12.72%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6d9a606...f00a7b8. Read the comment docs.

@alumi alumi assigned alumi and unassigned totakke Dec 25, 2017
@alumi alumi assigned totakke and unassigned alumi Dec 25, 2017
Copy link
Member

@totakke totakke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you. I confirmed the behavior. However, I feel confusion about output args of convert... That doesn't seem intuitive, but what is better way...

Anyway, please remove unused requires.

[cljam.algo.convert :as convert]))
[cljam.algo.convert :as convert]
[cljam.io.sam :as sam]
[cljam.io.sam.util.sequence :as sam-seq]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cljam.io.sam and cljam.io.sam.util.sequence don't seem to be used.

@totakke totakke merged commit 60fe37c into master Dec 25, 2017
@totakke totakke deleted the feature/more-convert branch December 25, 2017 12:02
@totakke
Copy link
Member

totakke commented Dec 25, 2017

Thanks for the fix.

@alumi
Copy link
Member Author

alumi commented Dec 25, 2017

Thank you for the helpful discussion!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants