-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix bugs in BCF I/O #168
Fix bugs in BCF I/O #168
Conversation
Codecov Report
@@ Coverage Diff @@
## master #168 +/- ##
==========================================
+ Coverage 86.53% 86.87% +0.33%
==========================================
Files 73 73
Lines 5624 5663 +39
Branches 491 481 -10
==========================================
+ Hits 4867 4920 +53
+ Misses 266 262 -4
+ Partials 491 481 -10
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for fixing those issues! Just added a couple of minor comments.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
@athos Thank you for the comments! I've fixed them in c8172d7...5f030a7 |
LGTM 👍I'll merge it. |
Summary
This PR fixes miscellaneous bugs in BCF reader/writer
\newline
at its endidx
s of FILTER/INFO/FORMAT are not allowed0x80–0x87
,0x8000–0x8007
,0x80000000–0x80000007
0x7F800001
END
info is not referred to when encoding reference lengthTests
lein check
🆗lein test :all
🆗lein cloverage
🆗lein eastwood
🆗