Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Apply cljfmt #191

Merged
merged 2 commits into from
Apr 17, 2020
Merged

Apply cljfmt #191

merged 2 commits into from
Apr 17, 2020

Conversation

alumi
Copy link
Member

@alumi alumi commented Apr 17, 2020

  • Added a GitHub Action for cljfmt check
  • Fixed current source codes to pass the check

@alumi alumi requested a review from a team as a code owner April 17, 2020 07:10
@alumi alumi requested review from athos and niyarin and removed request for a team April 17, 2020 07:10
@codecov
Copy link

codecov bot commented Apr 17, 2020 •
edited
Loading

Codecov Report

Merging #191 into master will not change coverage.
The diff coverage is 36.47%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #191   +/-   ##
=======================================
  Coverage   86.81%   86.81%           
=======================================
  Files          77       77           
  Lines        6205     6205           
  Branches      516      516           
=======================================
  Hits         5387     5387           
  Misses        302      302           
  Partials      516      516
Impacted Files Coverage Δ
src/cljam/io/bam/core.clj 100.00% <ø> (ø)
src/cljam/io/bam/decoder.clj 86.40% <0.00%> (ø)
src/cljam/io/bam/encoder.clj 71.83% <0.00%> (ø)
src/cljam/io/pileup.clj 59.37% <ø> (ø)
src/cljam/io/sam/writer.clj 73.07% <0.00%> (ø)
src/cljam/tools/cli.clj 59.03% <0.00%> (ø)
src/cljam/util.clj 91.22% <ø> (ø)
src/cljam/io/dict/writer.clj 85.96% <12.50%> (ø)
src/cljam/io/vcf/writer.clj 84.39% <78.57%> (ø)
src/cljam/io/sam/util/header.clj 97.36% <100.00%> (ø)
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dc32d97...a779a4d. Read the comment docs.

athos
athos approved these changes Apr 17, 2020
View reviewed changes
Copy link
Member

@athos athos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@alumi alumi unassigned athos Apr 17, 2020
niyarin
niyarin approved these changes Apr 17, 2020
View reviewed changes
Copy link
Contributor

@niyarin niyarin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM:+1:

@alumi alumi merged commit a6bbdde into master Apr 17, 2020
@alumi alumi deleted the feature/cljfmt branch April 17, 2020 08:44
@alumi
Copy link
Member Author

alumi commented Apr 17, 2020

@athos @niyarin Thanks for your reviews!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@niyarin niyarin niyarin approved these changes

@athos athos athos approved these changes

Assignees

@niyarin niyarin

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alumi @athos @niyarin