Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix warnings and errors reported by clj-kondo #192

Merged
merged 1 commit into from
Apr 22, 2020
Merged

Conversation

alumi
Copy link
Member

@alumi alumi commented Apr 21, 2020

summary
  • Fixed warnings and errors reported by clj-kondo
    • Explicit :refer
    • Remove unused require, import, args and local vars
    • Remove redundant do
    • and some more warnings
  • Added a config file .clj-kondo/config.edn for suppressing false-positive errors
checks
  • lein check 🆗
  • lein test :all 🆗

@alumi alumi requested a review from a team as a code owner April 21, 2020 05:18
@alumi alumi requested review from yito88 and r6eve and removed request for a team April 21, 2020 05:18
@codecov
Copy link

codecov bot commented Apr 21, 2020

Codecov Report

Merging #192 into master will increase coverage by 0.09%.
The diff coverage is 68.75%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #192      +/-   ##
==========================================
+ Coverage   86.81%   86.91%   +0.09%     
==========================================
  Files          77       77              
  Lines        6205     6197       -8     
  Branches      516      516              
==========================================
- Hits         5387     5386       -1     
+ Misses        302      295       -7     
  Partials      516      516              
Impacted Files Coverage Δ
src/cljam/algo/sorter.clj 92.23% <ø> (ø)
src/cljam/io/bam/reader.clj 92.59% <ø> (ø)
src/cljam/io/bam_index/core.clj 82.05% <0.00%> (+2.05%) ⬆️
src/cljam/io/bam_index/writer.clj 84.37% <ø> (ø)
src/cljam/io/bcf/writer.clj 89.67% <ø> (-0.05%) ⬇️
src/cljam/io/bed.clj 90.74% <ø> (ø)
src/cljam/io/dict/core.clj 63.63% <0.00%> (+5.30%) ⬆️
src/cljam/io/dict/writer.clj 85.96% <ø> (ø)
src/cljam/io/fasta_index/core.clj 91.66% <0.00%> (+1.87%) ⬆️
src/cljam/io/sam/util.clj 92.30% <ø> (ø)
... and 13 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a6bbdde...2a4fc99. Read the comment docs.

.clj-kondo/config.edn Outdated Show resolved Hide resolved
Copy link
Contributor

@r6eve r6eve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@yito88 yito88 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@alumi alumi merged commit 0f7bc1f into master Apr 22, 2020
@alumi alumi deleted the fix/clj-kondo branch April 22, 2020 01:03
@alumi
Copy link
Member Author

alumi commented Apr 22, 2020

@r6eve @yito88 Thanks for your reviews! 😃

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants