Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Run lein check on CI #199

Merged
merged 1 commit into from
Jun 3, 2020
Merged

Run lein check on CI #199

merged 1 commit into from
Jun 3, 2020

Conversation

alumi
Copy link
Member

@alumi alumi commented Jun 3, 2020

Added a step to run lein check on CI (for only Java 11).
It will report reflection warnings using workflow commands.

@alumi alumi requested a review from a team as a code owner June 3, 2020 02:17
@alumi alumi requested review from niyarin and yito88 and removed request for a team June 3, 2020 02:17
yito88
yito88 approved these changes Jun 3, 2020
View reviewed changes
Copy link
Contributor

@yito88 yito88 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! LGTM

niyarin
niyarin approved these changes Jun 3, 2020
View reviewed changes
Copy link
Contributor

@niyarin niyarin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@alumi alumi merged commit 2327480 into master Jun 3, 2020
@alumi alumi deleted the feature/add-check branch June 3, 2020 06:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yito88 yito88 yito88 approved these changes

@niyarin niyarin niyarin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alumi @niyarin @yito88