Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found sometimes BAM random reading function like
(cljam.io/read-alignment reader {:chr "chr1" :start 1 :end 10000000 :depth :deep})
returns fewer alignments than actual for certain BAM files.The root cause was in
cljam.bam.reader/read-alignments*
function:where
cljam.bam.reader/read-to-finish
returns a lazy sequence:Because
(.seek ^BGZFInputStream (.reader rdr) begin)
for all spans are called when flattened,read-to-finish
reads alignments in the last span only. (+ the first one in all spans)This problem is now fixed by seeking just before reading data
and its effect to performance of reading from single long span is limited.