-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use bgzip as default for writing .gz
files
#253
Conversation
Codecov Report
@@ Coverage Diff @@
## master #253 +/- ##
==========================================
- Coverage 88.70% 88.60% -0.11%
==========================================
Files 76 76
Lines 6305 6308 +3
Branches 438 441 +3
==========================================
- Hits 5593 5589 -4
- Misses 274 278 +4
- Partials 438 441 +3
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
Fixes #251
This PR changes the behavior of
cljam.util/compressor-output-stream
.It now returns
BGZFOutputStream
instead ofGzipCompressorOutputStream
for files with.gz
extension.Since BGZIP is just a special case of GZIP, existing codes using
cljam.util/compressor-output-stream
with.gz
should still work.To get
GzipCompressorOutputStream
, we can use the 2nd argument or.gzip
extension.This PR also includes