Remove nth's linear search overhead in BCF reader #294
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When I was profiling the BCF reader before, I found that the invocation to
nth
took up most of the time, which does linear search per sample.This PR removes the overhead of the linear search and improve the performance of the BCF reader by replacing the sequential collection returned from
read-typed-value
with a vector, not a lazy sequence.Here are the profiling results before and after the change:
By this fix, the BCF reader is now roughly 7x faster than before: