Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a function to clone bam reader. #39

Merged
merged 1 commit into from
Apr 7, 2017
Merged

Conversation

alumi
Copy link
Member

@alumi alumi commented Apr 6, 2017

Reading BAM header and BAI will be time-consuming when BAM has a lot of refs.
Usually we create one reader per ref when process alignments in parallel and reading same BAM header and BAI repeatedly caused degradation of performance.

This PR adds clone-reader function to clone BAMReader reconstructing stateful reader objects of Java.

Copy link
Contributor

@ayamada ayamada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I checked this PR and #41 .
I think this is good.

@totakke totakke merged commit 52539b7 into master Apr 7, 2017
totakke added a commit that referenced this pull request Apr 7, 2017
Add a function to clone bam reader.
@totakke totakke deleted the feature/clone-bam-reader branch April 7, 2017 08:12
@totakke
Copy link
Member

totakke commented Apr 7, 2017

Thanks for enhancement and review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants