Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added ?T option to run-tests.sh #351

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

pkhanpara
Copy link

added ?T option to run-tests.sh to ignore ansi styling mismatch errors and recaptured the outputs. Fixing #345

@pkhanpara pkhanpara changed the title added ?T option to run-tests.sh #345 added ?T option to run-tests.sh Jul 7, 2022
@abitrolly
Copy link
Collaborator

We will need test for highlighting, but that could be another issue to keep this minimal.

Looks good, but tests are failing. Probably escaping got wrong at some point so the server returns StackOverflow answers instead of stored data.

@pkhanpara
Copy link
Author

I've fixed the escaping. Now it may show one unrelated test failing in both modes, which looks like a different issue. And there is one more unrelated test failing in standalone mode.

@abitrolly
Copy link
Collaborator

Added #352 for failing test.

I would actually get rid of eval logic, because I don't really get what it does. But it doesn't seem relevant to this PR.

Need @chubin feedback on the whole idea of suppressing colors in tests.

@pkhanpara
Copy link
Author

@chubin what do you think about suppressing colors in tests? Feel free to point out an alternative approach if you don't feel like this is the right way to do it. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants