Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add null safety support #33

Merged
merged 3 commits into from
Mar 27, 2021
Merged

Add null safety support #33

merged 3 commits into from
Mar 27, 2021

Conversation

areille
Copy link
Contributor

@areille areille commented Mar 5, 2021 •
edited
Loading

This PR closes #31 .

I followed the steps mentioned on this page.

Some points to mention :

  • Widget-returning functions which returned null now return const SizedBox(), which is an empty Widget
  • as tere is not many tests for this plugin, we could use some more manual testing

KabinManandhar
KabinManandhar previously approved these changes Mar 9, 2021
View reviewed changes
@areille
Copy link
Contributor Author

areille commented Mar 12, 2021

Last example demo does not work, will have a look at it.

@areille
Copy link
Contributor Author

areille commented Mar 12, 2021

@KabinManandhar this should be ok now ! 👍

@vjrj
Copy link

vjrj commented Mar 19, 2021

Thanks @areille ! The ProcessTimelinePage of the examples does not work well:

2021-11-19-23-28-52-screenshot

I tried to find the bug today without success.

@chulwoo-park
Copy link
Owner

Sorry I'm toooooo late.

I haven't been paying attention.
I'll review it over the weekend and distribute it right away if there is no problem!

THX!

@chulwoo-park chulwoo-park self-assigned this Mar 27, 2021
@chulwoo-park chulwoo-park added this to the 0.1.0 milestone Mar 27, 2021
@chulwoo-park
Copy link
Owner

chulwoo-park commented Mar 27, 2021 •
edited
Loading

@areille
Thank you so much for working on it.

I was revert this changes(please check once for anything missing):

  • Widget-returning functions which returned null now return const SizedBox(), which is an empty Widget

because connectors is positioned by null checkes in timeline tile builder.

@vjrj
Please check the bug in 6d4cf0e. It was fine when I tried it.

@chulwoo-park chulwoo-park assigned areille and unassigned chulwoo-park Mar 27, 2021
@chulwoo-park chulwoo-park self-requested a review March 27, 2021 06:44
@chulwoo-park chulwoo-park mentioned this pull request Mar 27, 2021
Closed
chulwoo-park
chulwoo-park previously approved these changes Mar 27, 2021
View reviewed changes
@vjrj
Copy link

vjrj commented Mar 27, 2021

@chulwoo-park yes, work now for me. Thanks indeed for both of you

@chulwoo-park chulwoo-park changed the base branch from main to develop March 27, 2021 08:00
@chulwoo-park chulwoo-park merged commit 91bb0bc into chulwoo-park:develop Mar 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KabinManandhar KabinManandhar KabinManandhar left review comments

@chulwoo-park chulwoo-park chulwoo-park left review comments

Assignees

@areille areille

Labels
None yet
Projects
None yet
Milestone
0.1.0
Development

Successfully merging this pull request may close these issues.

Migrate to sound null safety
4 participants
@areille @vjrj @chulwoo-park @KabinManandhar